Run Marionette tests for TSAN builds as well
Categories
(Firefox Build System :: Task Configuration, enhancement)
Tracking
(firefox133 fixed)
Tracking | Status | |
---|---|---|
firefox133 | --- | fixed |
People
(Reporter: whimboo, Assigned: jmaher)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
Right now Marionette tests are only run for ASAN builds but miss TSAN. By inspecting the YAML definition I cannot see why:
https://searchfox.org/mozilla-central/source/taskcluster/kinds/test/marionette.yml
Maybe it requires some setting outside of that specific file?
Assignee | ||
Comment 1•9 months ago
|
||
these tests timeout after 90 minutes:
https://treeherder.mozilla.org/jobs?repo=try&revision=5a60e3051b14a49884920af7f5f9648a6330bdbf
we might want to wait until we can chunk the tests.
Reporter | ||
Comment 2•9 months ago
|
||
Sounds fine. Marking bug 1916456 as dependency.
Also please note that the 2 perma failing restart tests (that would have to be fixed first as well) are causing an extra 16min delay! I should take a look at those first as well. Not sure if they are actually based on the same underlying issue. I would have to test, but this won't happen this week.
https://treeherder.mozilla.org/logviewer?job_id=472911439&repo=try&lineNumber=60738
https://treeherder.mozilla.org/logviewer?job_id=472911439&repo=try&lineNumber=61353
Assignee | ||
Comment 3•9 months ago
|
||
this didn't work as well as I would have liked:
https://treeherder.mozilla.org/jobs?repo=try&revision=a73e75b536b03a62cd73b4364c9e46531a1d115e
first 2 chunks barely ran anything, and the 3rd chunk ran too much and hit the time limit. more work when I am back from PTO
Reporter | ||
Comment 4•9 months ago
|
||
The tricky part are the restart tests! Each and every shutdown and startup of Firefox takes a good amount of time. If we have trouble to balance out between the different chunks I can expect more failures in the future if more of such tests are getting added.
Reporter | ||
Comment 5•8 months ago
|
||
TSAN builds are slow as well. So we might need bug 1921411 resolved first too.
Assignee | ||
Comment 6•8 months ago
|
||
Updated•8 months ago
|
Comment 8•8 months ago
|
||
Backed out for causing tsan marionette failures.
- Backout link
- Push with failures
- Failure Log
- Failure line: SUMMARY: ThreadSanitizer: data race /builds/worker/checkouts/gecko/toolkit/xre/ProfileReset.h:72:35 in ProfileResetCleanupAsyncTask::Run()
Assignee | ||
Comment 10•8 months ago
|
||
thanks, this appears to be something tsan is good at catching, I filed a bug just so I can move forward with this and ideally the tsan race will get fixed soon.
Reporter | ||
Comment 11•8 months ago
|
||
Joel, a patch is already attached on bug 1925378 so I would prefer to actually wait with landing the patch on this bug until the bug is fixed.
Reporter | ||
Comment 12•7 months ago
|
||
Bug 1925378 is fixed now. So we can try to land the patch again, right?
Assignee | ||
Updated•7 months ago
|
Comment 13•7 months ago
|
||
Comment 14•7 months ago
|
||
bugherder |
Description
•